trampoline functionalty #1106
Open
trampoline functionalty #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Salon <[email protected]>
Co-authored-by: Salon <[email protected]>
Spooky-Firefox
force-pushed
the
exeption_trampoline
branch
from
c900f83 to
4c855d6
Compare
added 2 commits
October 6, 2025 16:18
AfoHT
requested changes
Oct 8, 2025
Comment on lines
+1
to
+11
| //! examples/bouncy_trampoline.rs | ||
| #![no_std] | ||
| #![no_main] | ||
| #![deny(warnings)] | ||
| #![deny(unsafe_code)] | ||
| #![deny(missing_docs)] | ||
|
|
||
| use panic_semihosting as _; | ||
|
|
||
| // `examples/bouncy_trampoline.rs` testing trampoline feature |
There was a problem hiding this comment.
Nitpick: Filename and comment are disagreeing :)
|
|
||
| ### Changed | ||
|
|
||
| - changed (sysclk % timer_hz) == 0 to sysclk.is_multiple_of(timer_hz) to make clippy happy as required to CI. |
There was a problem hiding this comment.
CI always uses latest stable Rust, so new versions bring in new lints/defaults all the time :)
Thank you for dealing with this, could you split out the 'rtic-monotonics' changes into a separate commit? If you want you could even create a separate PR for this, to help your colleague, that can be fast-tracked into master branch that way :)
Great you added to the CHANGELOG, but please add new entries above, building like a stack. Please cleanup the commentary and the double ### Changed headers while you're at it :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "trampoline" feature for hardware tasks in RTIC, allowing an interrupt handler to pend another interrupt (the trampoline), which then executes the actual task code. This improves interrupt handling flexibility and source masking safety( As some exceptions can't be masked through NVIC). The implementation includes changes to parsing, code generation, and error checking for correct usage. The PR also contains a small fix to CI and a minor improvement to the rtic-monotonics crate for clippy compliance.
Trampoline Feature for Hardware Tasks
trampolineargument in hardware task definitions, allowing the interrupt handler to pend another interrupt (the trampoline), which runs the task code. This is parsed and stored inHardwareTaskArgs. [1] [2]Documentation and Changelog Updates
Miscellaneous Improvements
is_multiple_of()inrtic-monotonicsfor clippy compliance and CI passing. [1] [2]These changes collectively improve the flexibility and safety of interrupt handling in RTIC, while also addressing minor CI and linting issues.
For more details, see issue #1088.